Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

register scheme for controller-manager #96133

Merged
merged 1 commit into from
Nov 4, 2020
Merged

register scheme for controller-manager #96133

merged 1 commit into from
Nov 4, 2020

Conversation

jiahuif
Copy link
Member

@jiahuif jiahuif commented Nov 3, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR implements scheme registering for group controllermanager.config.k8s.io, so that we can use resources under this group.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 3, 2020
@jiahuif
Copy link
Member Author

jiahuif commented Nov 3, 2020

/sig cloud-provider

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Nov 3, 2020
@jiahuif
Copy link
Member Author

jiahuif commented Nov 3, 2020

/assign @cheftako

@cheftako
Copy link
Member

cheftako commented Nov 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2020
@jiahuif
Copy link
Member Author

jiahuif commented Nov 3, 2020

/cc @cici37

cici37
cici37 reviewed Nov 3, 2020
View reviewed changes
staging/src/k8s.io/controller-manager/config/register.go
// Adds the list of known types to the given scheme.
func addKnownTypes(scheme *runtime.Scheme) error {
scheme.AddKnownTypes(SchemeGroupVersion,
&LeaderMigrationConfiguration{},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add GenericControllerManagerConfiguration?

Copy link
Member Author

@jiahuif jiahuif Nov 3, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, no. There is no meta in GenericControllerManagerConfiguration, indicating it is never used directly through scheme.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubled checked. GenericControllerManagerConfiguration is used as nested only by KubeControllerManagerConfiguration and CloudControllerManagerConfiguration, the latter two are indeed registered.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right.

@cici37
Copy link
Contributor

cici37 commented Nov 3, 2020

/lgtm

@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 3, 2020
@cheftako
Copy link
Member

cheftako commented Nov 4, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, jiahuif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit e01b42d into kubernetes:master Nov 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 4, 2020
@jiahuif jiahuif deleted the feature/controller-manager/scheme-register branch November 4, 2020 06:46
@jiahuif jiahuif mentioned this pull request Nov 4, 2020
Closed
@jiahuif jiahuif mentioned this pull request Feb 5, 2021
Closed
12 tasks
This was referenced Mar 2, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cici37 cici37 cici37 left review comments

@mtaufen mtaufen Awaiting requested review from mtaufen

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@cheftako cheftako

@cici37 cici37

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jiahuif @cheftako @cici37 @fedebongio @k8s-ci-robot